fix(audio): reduce live transcription fragmentation - #711
Open
Bbrizly wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The live pipeline was still using a 400ms VAD redemption time:
let redemption_time = if cfg!(target_os = "macos") { 400 } else { 400 };That can split speech at normal pauses and send Parakeet short chunks with very little context.
vad.rsalready documents this problem and has a test comparing 400ms vs 2000ms. This PR changes the live pipeline to use 2000ms as well.I found this after comparing Meetily's live Parakeet transcript with Parakeet run directly on Meetily's saved recording. The saved audio transcribed much better, while the live transcript was broken into short fragments.
Related Issue
Related: #171, #604, #657, #578
I couldn't find an existing issue for this exact 400ms VAD setting.
Type of Change
Testing
There is already a
test_vad_400ms_vs_2000ms_segmentation()test invad.rs.Documentation
Checklist
Screenshots (if applicable)
N/A
Additional Notes
This only changes the live VAD redemption time from 400ms to 2000ms.